Resubmitting last unsuccessful build instead of last failed build #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443
When an agent gets disconnected (AWS interruption) the job is set to aborted.
Currently the job that gets resubmitted is the last failed job, which is not the job that was running on the agent that got disconnected, leading to the wrong parameters being used with the resubmitted job.
This fixes the issue by using
getLastUnsuccessfulBuild
to get the last job that ran before the agent went down.Testing done
Unit testing with
mvn test
and locallySubmitter checklist